----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105530/ -----------------------------------------------------------
Review request for Calligra and C. Boemann. Description ------- Seems the code in KoOdfNumberStyles::saveOdfTextStyle(...) never got finished after copying some template code. Currently not only has strange code, but also writes garbage: * "number:text-style" instead of "number:text-content" used for variable position * suffix and prefix-suffix-extension written in wrong element Attached patch fixes that (also avoids unneeded pass-by-copy for NumericStyleFormat type parameter elsewhere in sourcefile). Okay to backport to 2.5? Diffs ----- libs/odf/KoOdfNumberStyles.h 63ff036 libs/odf/KoOdfNumberStyles.cpp 57e83c9 Diff: http://git.reviewboard.kde.org/r/105530/diff/ Testing ------- Thanks, Friedrich W. H. Kossebau
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel