-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105528/
-----------------------------------------------------------
Review request for Calligra, Inge Wallin and C. Boemann.
Description
-------
As can be seen e.g. in odf/odt/OpenDocument-v1.1.odt from the calligratests,
some OOo versions did not use commas as separators for the offset values in the
value "rect(...)" for the attribute "fo:clip". So the parsing fails, for the
given document e.g. with
--- 8< ---
KoUnit::parseValue: KoUnit::parseValue: Unit "cm0cm0cm0cm" is not supported,
please report.
--- 8< ---
And while I created the attached patch with a workaround I changed the code to
also:
* detect "auto" values in rect(...)
* check number of values in rect(...)
* handle negative values in rect(...)
Okay to backport to 2.5?
Diffs
-----
libs/flake/KoOdfWorkaround.h 18b801f
libs/flake/KoOdfWorkaround.cpp 9b8fce9
plugins/pictureshape/PictureShape.h 3937573
plugins/pictureshape/PictureShape.cpp 40c609b
Diff: http://git.reviewboard.kde.org/r/105528/diff/
Testing
-------
Thanks,
Friedrich W. H. Kossebau
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
