----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105428/ -----------------------------------------------------------
Review request for Calligra. Description ------- Real reason for this patch is that KFileItem::pixmap(...) is broken for items constructed with KFileItem(mode_t, mode_t, KUrl, bool) and no other mimetype related call before the one to ::pixmap. It will always return a pixmap with the "unknown" icon. You can see this for files for which there is no preview created (for whatever reason). But the patch fixes also the size mismatch between the fetched previews (200x200) and the usual ODF preview of 128x128 as well as that the preview just from the icon is set in size 128. And makes the code shorter. A more complete patch I have locally also fetches previews in small sizes separately from the big previews, and those only on demand. That should reduce the memory used in total. But that will come later with the patch to support templates also from LO folders, this is just for fixing the stuff mentioned above. Diffs ----- libs/main/KoRecentDocumentsPane.cpp 521c7e6 Diff: http://git.reviewboard.kde.org/r/105428/diff/ Testing ------- Thanks, Friedrich W. H. Kossebau
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
