> On Dec. 20, 2011, 4:19 a.m., Thorsten Zachmann wrote: > > plugins/pictureshape/PictureShape.h, lines 37-38 > > <http://git.reviewboard.kde.org/r/103402/diff/1/?file=43231#file43231line37> > > > > Please move to the private section so that it is more clear it is > > private. > > Please move the implementation to the cpp file.
done > On Dec. 20, 2011, 4:19 a.m., Thorsten Zachmann wrote: > > plugins/pictureshape/PictureShape.h, lines 40-70 > > <http://git.reviewboard.kde.org/r/103402/diff/1/?file=43232#file43232line40> > > > > How about moving that to the private section of the PictureShape making > > it real private? Is not possible. MOC doesn't like it. - Silvio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103402/#review9111 ----------------------------------------------------------- On Dec. 13, 2011, 12:16 p.m., Silvio Heinrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103402/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2011, 12:16 p.m.) > > > Review request for Calligra. > > > Description > ------- > > It's a feature meant to be applied after the release is out. > It adds a GUI to the pictureshape tool for cropping and setting the color > mode. > The scaling of the loaded picture is done in a background thread. > > > Diffs > ----- > > plugins/pictureshape/CMakeLists.txt 5e6c922 > plugins/pictureshape/ChangeImageCommand.h 44244d4 > plugins/pictureshape/ChangeImageCommand.cpp 66decc4 > plugins/pictureshape/ClippingRect.h PRE-CREATION > plugins/pictureshape/ClippingRect.cpp PRE-CREATION > plugins/pictureshape/CropWidget.h PRE-CREATION > plugins/pictureshape/CropWidget.cpp PRE-CREATION > plugins/pictureshape/GreyscaleFilterEffect.h e858599 > plugins/pictureshape/GreyscaleFilterEffect.cpp ed8032f > plugins/pictureshape/MonoFilterEffect.h 2696378 > plugins/pictureshape/MonoFilterEffect.cpp 115b068 > plugins/pictureshape/PictureShape.h fc3c221 > plugins/pictureshape/PictureShape.cpp 68eeb6a > plugins/pictureshape/PictureShapeConfigWidget.h 7249e7b > plugins/pictureshape/PictureShapeConfigWidget.cpp a85e764 > plugins/pictureshape/PictureTool.h 5c1dd5f > plugins/pictureshape/PictureTool.cpp aef9304 > plugins/pictureshape/SelectionRect.h PRE-CREATION > plugins/pictureshape/SelectionRect.cpp PRE-CREATION > plugins/pictureshape/WatermarkFilterEffect.h f8a5b05 > plugins/pictureshape/WatermarkFilterEffect.cpp 513d44f > plugins/pictureshape/filters/GreyscaleFilterEffect.h PRE-CREATION > plugins/pictureshape/filters/GreyscaleFilterEffect.cpp PRE-CREATION > plugins/pictureshape/filters/MonoFilterEffect.h PRE-CREATION > plugins/pictureshape/filters/MonoFilterEffect.cpp PRE-CREATION > plugins/pictureshape/filters/WatermarkFilterEffect.h PRE-CREATION > plugins/pictureshape/filters/WatermarkFilterEffect.cpp PRE-CREATION > plugins/pictureshape/forms/wdgPictureTool.ui PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/103402/diff/diff > > > Testing > ------- > > > Thanks, > > Silvio Heinrich > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
