----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103402/#review9111 -----------------------------------------------------------
Hello Silvio, can you please attach a big diff against master as this seems to be a patch series making it very hard to see what is new compared to master. Thanks, Thorsten plugins/pictureshape/PictureShape.h <http://git.reviewboard.kde.org/r/103402/#comment7536> Please only leave one space beween the type and the variable. That also goes for the other places. plugins/pictureshape/PictureShape.h <http://git.reviewboard.kde.org/r/103402/#comment7537> Please move to the private section so that it is more clear it is private. Please move the implementation to the cpp file. plugins/pictureshape/PictureShape.h <http://git.reviewboard.kde.org/r/103402/#comment7538> How about moving that to the private section of the PictureShape making it real private? - Thorsten Zachmann On Dec. 13, 2011, 12:16 p.m., Silvio Heinrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103402/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2011, 12:16 p.m.) > > > Review request for Calligra. > > > Description > ------- > > It's a feature meant to be applied after the release is out. > It adds a GUI to the pictureshape tool for cropping and setting the color > mode. > The scaling of the loaded picture is done in a background thread. > > > Diffs > ----- > > plugins/pictureshape/CMakeLists.txt 5e6c922 > plugins/pictureshape/CMakeLists.txt 4d841f6 > plugins/pictureshape/CMakeLists.txt 6d12591 > plugins/pictureshape/ChangeImageCommand.h 44244d4 > plugins/pictureshape/ChangeImageCommand.cpp 66decc4 > plugins/pictureshape/ClippingRect.h PRE-CREATION > plugins/pictureshape/ClippingRect.h 289774d > plugins/pictureshape/CropWidget.h PRE-CREATION > plugins/pictureshape/CropWidget.h 56e0f88 > plugins/pictureshape/CropWidget.h 2cf685d > plugins/pictureshape/CropWidget.h b2fe827 > plugins/pictureshape/CropWidget.h f946770 > plugins/pictureshape/CropWidget.h 8ee149c > plugins/pictureshape/CropWidget.cpp PRE-CREATION > plugins/pictureshape/CropWidget.cpp b7c1aea > plugins/pictureshape/CropWidget.cpp 0c537b9 > plugins/pictureshape/CropWidget.cpp 4c0aeaf > plugins/pictureshape/CropWidget.cpp 4dd02b3 > plugins/pictureshape/CropWidget.cpp bf6ea13 > plugins/pictureshape/GreyscaleFilterEffect.h e858599 > plugins/pictureshape/GreyscaleFilterEffect.cpp ed8032f > plugins/pictureshape/MonoFilterEffect.h 2696378 > plugins/pictureshape/MonoFilterEffect.cpp 115b068 > plugins/pictureshape/PictureShape.h fc3c221 > plugins/pictureshape/PictureShape.h a2bb34f > plugins/pictureshape/PictureShape.h f2450d8 > plugins/pictureshape/PictureShape.h e98ae41 > plugins/pictureshape/PictureShape.h 7b72619 > plugins/pictureshape/PictureShape.h 9063fe7 > plugins/pictureshape/PictureShape.h af98d7b > plugins/pictureshape/PictureShape.h e91af38 > plugins/pictureshape/PictureShape.h 9bb248c > plugins/pictureshape/PictureShape.cpp 68eeb6a > plugins/pictureshape/PictureShape.cpp bd7b1a3 > plugins/pictureshape/PictureShape.cpp eda2548 > plugins/pictureshape/PictureShape.cpp e2ebd82 > plugins/pictureshape/PictureShape.cpp 58a37c4 > plugins/pictureshape/PictureShape.cpp b8f76d0 > plugins/pictureshape/PictureShape.cpp f21537d > plugins/pictureshape/PictureShape.cpp 148515e > plugins/pictureshape/PictureShape.cpp 254140f > plugins/pictureshape/PictureShape.cpp c99e33c > plugins/pictureshape/PictureShape.cpp bebd149 > plugins/pictureshape/PictureShape.cpp a8c4f6f > plugins/pictureshape/PictureShapeConfigWidget.h 7249e7b > plugins/pictureshape/PictureShapeConfigWidget.cpp a85e764 > plugins/pictureshape/PictureTool.h 5c1dd5f > plugins/pictureshape/PictureTool.h 6b13a15 > plugins/pictureshape/PictureTool.h 1760dc6 > plugins/pictureshape/PictureTool.h c72241c > plugins/pictureshape/PictureTool.h fe94b06 > plugins/pictureshape/PictureTool.cpp aef9304 > plugins/pictureshape/PictureTool.cpp c044261 > plugins/pictureshape/PictureTool.cpp bc7e6f7 > plugins/pictureshape/PictureTool.cpp 3309efa > plugins/pictureshape/PictureTool.cpp 6f146bd > plugins/pictureshape/SelectionRect.h PRE-CREATION > plugins/pictureshape/SelectionRect.h 63209c2 > plugins/pictureshape/SelectionRect.h 5e748be > plugins/pictureshape/SelectionRect.h 596d0d9 > plugins/pictureshape/SelectionRect.h f3e0015 > plugins/pictureshape/SelectionRect.h 641116c > plugins/pictureshape/SelectionRect.h 6d06dd8 > plugins/pictureshape/SelectionRect.cpp PRE-CREATION > plugins/pictureshape/SelectionRect.cpp 345de9d > plugins/pictureshape/WatermarkFilterEffect.h f8a5b05 > plugins/pictureshape/WatermarkFilterEffect.cpp 513d44f > plugins/pictureshape/filters/GreyscaleFilterEffect.h PRE-CREATION > plugins/pictureshape/filters/GreyscaleFilterEffect.cpp PRE-CREATION > plugins/pictureshape/filters/MonoFilterEffect.h PRE-CREATION > plugins/pictureshape/filters/MonoFilterEffect.cpp PRE-CREATION > plugins/pictureshape/filters/WatermarkFilterEffect.h PRE-CREATION > plugins/pictureshape/filters/WatermarkFilterEffect.cpp PRE-CREATION > plugins/pictureshape/filters/WatermarkFilterEffect.cpp 513d44f > plugins/pictureshape/forms/wdgPictureTool.ui PRE-CREATION > plugins/pictureshape/forms/wdgPictureTool.ui cab9729 > plugins/pictureshape/forms/wdgPictureTool.ui ae66bc8 > > Diff: http://git.reviewboard.kde.org/r/103402/diff/diff > > > Testing > ------- > > > Thanks, > > Silvio Heinrich > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
