----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102863/#review7683 -----------------------------------------------------------
We are moving, but as I warned you on irc there si quite a while to go yet Hang in :) libs/kotext/styles/KoParagraphStyle.h <http://git.reviewboard.kde.org/r/102863/#comment6615> There is no need to put this in the paragraph style, and i'm not sure we want it here. libs/kotext/styles/KoParagraphStyle.cpp <http://git.reviewboard.kde.org/r/102863/#comment6627> Since I later say this method should be called on all but the deleted style, you should check if parentStyle() == newStyle and only then set a new parentStyle libs/kotext/styles/KoParagraphStyle.cpp <http://git.reviewboard.kde.org/r/102863/#comment6616> In any case this line should not be done libs/kotext/styles/KoStyleManager.cpp <http://git.reviewboard.kde.org/r/102863/#comment6626> See my comments below where this method is called plugins/textshape/CMakeLists.txt <http://git.reviewboard.kde.org/r/102863/#comment6617> please remove spaces plugins/textshape/CMakeLists.txt <http://git.reviewboard.kde.org/r/102863/#comment6618> please remove spaces plugins/textshape/dialogs/StyleManager.h <http://git.reviewboard.kde.org/r/102863/#comment6619> please remove spaces plugins/textshape/dialogs/StyleManager.cpp <http://git.reviewboard.kde.org/r/102863/#comment6620> one blank line will do plugins/textshape/dialogs/StyleManager.cpp <http://git.reviewboard.kde.org/r/102863/#comment6622> first of all this shouldn't be done immidiately. The user should still have a chance to select cancel plugins/textshape/dialogs/StyleManager.cpp <http://git.reviewboard.kde.org/r/102863/#comment6624> this method should be split in two one that does the unapply (and records the blocks somehow) and the part that does the apply should be done after the inheritance has been changed plugins/textshape/dialogs/StyleManager.cpp <http://git.reviewboard.kde.org/r/102863/#comment6623> you are calling this on the wrong style. It should be called on all styles except the deleted style plugins/textshape/dialogs/StyleManager.cpp <http://git.reviewboard.kde.org/r/102863/#comment6625> This is correct and should be done immediately even though the rest should be moved to ok/apply of the dialog plugins/textshape/dialogs/StyleManager.cpp <http://git.reviewboard.kde.org/r/102863/#comment6621> please remove blank line - C. Boemann On Oct. 26, 2011, 6:30 p.m., Inge Wallin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102863/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2011, 6:30 p.m.) > > > Review request for Calligra. > > > Description > ------- > > This patch is from Mojtaba Shahi Senobari, and implements deletion of styles > in the style manager. The tricky part is that if the deleted is used by some > paragraph they have to be assigned another paragraph. > > This is Moji's first patch here at the reviewboard. Be gentle. :) > > > Diffs > ----- > > libs/kotext/styles/KoParagraphStyle.h 3f9f40c > libs/kotext/styles/KoParagraphStyle.cpp cdf16a4 > libs/kotext/styles/KoStyleManager.h ac145f9 > libs/kotext/styles/KoStyleManager.cpp fbbc4ee > plugins/textshape/CMakeLists.txt 52fd060 > plugins/textshape/dialogs/StyleManager.h 93247b7 > plugins/textshape/dialogs/StyleManager.cpp 99ed8b8 > plugins/textshape/dialogs/StylesWidget.h 844bed8 > plugins/textshape/dialogs/StylesWidget.cpp 4f31a01 > > Diff: http://git.reviewboard.kde.org/r/102863/diff/diff > > > Testing > ------- > > I tested with a number of combinations of paragraph styles, and it seems to > work. > > > Thanks, > > Inge Wallin > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
