----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102863/#review7339 -----------------------------------------------------------
Ok this is quite a good start, however besides the minor cosmetic issues mentioned, there is also an issue regarding the actual change. Any style that has this style as parent must also be changed. Here I mean the styles in the stylemanager list of paragraph styles, and not the blocks The applyStyle actually overwrites any custom/auto formatting so this is something to improve. we'll have to see if it's a problem with applyStyle in generalt of if this code needs to take further steps so get the user expected behaviour. Finally is the style ever actually removed from the stylemanager libs/kotext/styles/KoStyleManager.h <http://git.reviewboard.kde.org/r/102863/#comment6404> arguments must start with small letters libs/kotext/styles/KoStyleManager.h <http://git.reviewboard.kde.org/r/102863/#comment6403> doc not duc libs/kotext/styles/KoStyleManager.cpp <http://git.reviewboard.kde.org/r/102863/#comment6405> arguments must start with small letters plugins/textshape/dialogs/StyleManager.h <http://git.reviewboard.kde.org/r/102863/#comment6406> method and argument names must start with small letters plugins/textshape/dialogs/StyleManager.h <http://git.reviewboard.kde.org/r/102863/#comment6407> even here after m_ Deleted must start with small letters But it doesn't seem to be used at all, so please remove plugins/textshape/dialogs/StyleManager.cpp <http://git.reviewboard.kde.org/r/102863/#comment6409> enable part of name should start with capitol E plugins/textshape/dialogs/StyleManager.cpp <http://git.reviewboard.kde.org/r/102863/#comment6410> no need for blank line here plugins/textshape/dialogs/StyleManager.cpp <http://git.reviewboard.kde.org/r/102863/#comment6408> method name should start with small letters plugins/textshape/dialogs/StyleManager.cpp <http://git.reviewboard.kde.org/r/102863/#comment6411> I would have preferred if we use .ui files for all new dialogs. Not a hard requirement but would be really appreciated. - C. Boemann On Oct. 14, 2011, 4:40 p.m., Inge Wallin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102863/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2011, 4:40 p.m.) > > > Review request for Calligra. > > > Description > ------- > > This patch is from Mojtaba Shahi Senobari, and implements deletion of styles > in the style manager. The tricky part is that if the deleted is used by some > paragraph they have to be assigned another paragraph. > > This is Moji's first patch here at the reviewboard. Be gentle. :) > > > Diffs > ----- > > libs/kotext/styles/KoStyleManager.h ac145f9 > libs/kotext/styles/KoStyleManager.cpp fbbc4ee > plugins/textshape/dialogs/StyleManager.h 93247b7 > plugins/textshape/dialogs/StyleManager.cpp 99ed8b8 > > Diff: http://git.reviewboard.kde.org/r/102863/diff/diff > > > Testing > ------- > > I tested with a number of combinations of paragraph styles, and it seems to > work. > > > Thanks, > > Inge Wallin > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
