----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101993/#review7106 -----------------------------------------------------------
This review has been submitted with commit e08bce93e67dcf0383001ccd3277693af2385fd8 by Boudewijn Rempt to branch master. - Commit Hook On July 18, 2011, 1:03 p.m., Boudewijn Rempt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101993/ > ----------------------------------------------------------- > > (Updated July 18, 2011, 1:03 p.m.) > > > Review request for Calligra. > > > Description > ------- > > This patch removes the buggy split-view functionality from KoMainWindow. > split-view has a number of problems: > > * crashes when removing views > * duplicates the actions so when a view is split you cannot e.g. delete a > shape with the delete key > * it is limited in that it can only show views on one document, instead of > splitting the view and then making it possible to show several documents > side-by-side > > After discussion on irc, we felt it was better to let the window manager > handle side-by-side views. To that end, a patch to optionally hide dockers if > the window loses focus will follow. > > > This addresses bugs 239309, 265200, 277953, and 278000. > http://bugs.kde.org/show_bug.cgi?id=239309 > http://bugs.kde.org/show_bug.cgi?id=265200 > http://bugs.kde.org/show_bug.cgi?id=277953 > http://bugs.kde.org/show_bug.cgi?id=278000 > > > Diffs > ----- > > flow/part/flow.rc bd2913a > karbon/data/karbon.rc 18c7156 > kpresenter/part/stage.rc d48fd3c > kpresenter/stage.rc 3e0f53d > krita/krita.rc 3d5d85d > libs/main/KoDocument.cpp 515911a > libs/main/KoMainWindow.h d44aff6 > libs/main/KoMainWindow.cpp c629827 > tables/tables.rc 0fde1b6 > words/part/words.rc 4e10d36 > > Diff: http://git.reviewboard.kde.org/r/101993/diff/diff > > > Testing > ------- > > Started several apps, opened and closed documents. > > > Thanks, > > Boudewijn Rempt > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
