----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102046/#review5955 -----------------------------------------------------------
plugins/reporting/Web/KoReportItemweb.cpp <http://git.reviewboard.kde.org/r/102046/#comment5259> CRASH! move this connect after a place where you instantiate QWebPage in line 65 (m_webPage=new QWebPage()) plugins/reporting/Web/KoReportItemweb.cpp <http://git.reviewboard.kde.org/r/102046/#comment5260> invalid connection here, wont work, and CRASH like for the above line plugins/reporting/Web/KoReportItemweb.cpp <http://git.reviewboard.kde.org/r/102046/#comment5261> what is Z here? plugins/reporting/Web/KoReportItemweb.cpp <http://git.reviewboard.kde.org/r/102046/#comment5262> why do we need this? looks like unfinished code plugins/reporting/Web/KoReportItemweb.cpp <http://git.reviewboard.kde.org/r/102046/#comment5263> memory leak, I guess m_webImage should be deleted in ~KoReportItemWeb() - Jarosław On Aug. 21, 2011, 10:11 a.m., Shreya Pandit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102046/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2011, 10:11 a.m.) > > > Review request for Calligra, Jarosław Staniek and Adam Pigg. > > > Summary > ------- > > Have made the change in Desktop files and filenames have been changed to > KoReportDesigneritemWeb etc. after uploading this.Please have a look as to > where the mistake lies. > > > This addresses bug no. > http://bugs.kde.org/show_bug.cgi?id=no > > > Diffs > ----- > > plugins/reporting/Web/CMakeLists.txt PRE-CREATION > plugins/reporting/Web/KoReportDesignerItemweb.h PRE-CREATION > plugins/reporting/Web/KoReportDesignerItemweb.cpp PRE-CREATION > plugins/reporting/Web/KoReportItemweb.h PRE-CREATION > plugins/reporting/Web/KoReportItemweb.cpp PRE-CREATION > plugins/reporting/Web/KoReportwebPlugin.h PRE-CREATION > plugins/reporting/Web/KoReportwebPlugin.cpp PRE-CREATION > plugins/reporting/Web/koreport_webplugin.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/102046/diff > > > Testing > ------- > > built > > > Thanks, > > Shreya > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
