----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102046/#review4960 -----------------------------------------------------------
plugins/reporting/web/KoReportDesignerItemweb.h <http://git.reviewboard.kde.org/r/102046/#comment4350> please change copyright to yours plugins/reporting/web/KoReportDesignerItemweb.h <http://git.reviewboard.kde.org/r/102046/#comment4351> please change to you plugins/reporting/web/KoReportDesignerItemweb.h <http://git.reviewboard.kde.org/r/102046/#comment4352> please always name parameters plugins/reporting/web/KoReportDesignerItemweb.cpp <http://git.reviewboard.kde.org/r/102046/#comment4353> why do we need to paint white bg? plugins/reporting/web/KoReportDesignerItemweb.cpp <http://git.reviewboard.kde.org/r/102046/#comment4354> please move m_reportDesigner->setModified(true); to separate line plugins/reporting/web/KoReportItemweb.cpp <http://git.reviewboard.kde.org/r/102046/#comment4355> rename to KoReportItemWeb plugins/reporting/web/KoReportItemweb.cpp <http://git.reviewboard.kde.org/r/102046/#comment4356> please change to report:url plugins/reporting/web/KoReportwebPlugin.h <http://git.reviewboard.kde.org/r/102046/#comment4357> please add your copyright plugins/reporting/web/KoReportwebPlugin.h <http://git.reviewboard.kde.org/r/102046/#comment4358> Please rename to KoReportWebPlugin plugins/reporting/web/KoReportwebPlugin.cpp <http://git.reviewboard.kde.org/r/102046/#comment4359> + your copyright - Jarosław On July 22, 2011, 9:22 a.m., Shreya Pandit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102046/ > ----------------------------------------------------------- > > (Updated July 22, 2011, 9:22 a.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Summary > ------- > > Web widget for reports.Please suggest changes > > > This addresses bug no. > http://bugs.kde.org/show_bug.cgi?id=no > > > Diffs > ----- > > plugins/reporting/CMakeLists.txt 42960d6 > plugins/reporting/web/KoReportDesignerItemweb.h PRE-CREATION > plugins/reporting/web/KoReportDesignerItemweb.cpp 6c1b43b > plugins/reporting/web/KoReportItemweb.h 07849c3 > plugins/reporting/web/KoReportItemweb.cpp cc5c7b9 > plugins/reporting/web/KoReportwebPlugin.h PRE-CREATION > plugins/reporting/web/KoReportwebPlugin.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/102046/diff > > > Testing > ------- > > built > > > Thanks, > > Shreya > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
