> On Aug. 3, 2011, 4:55 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeGroup.cpp, lines 63-76 > > <http://git.reviewboard.kde.org/r/102072/diff/4/?file=30652#file30652line63> > > > > A group shape can also have filter effects applied, so that must be > > taken into account too. > > And I think that now the group shape has a proper boundingRect() > > function, the size() function should return a correct size too. > > Yue Liu wrote: > I don't know if the non-zero size would break other things. > > Jan Hambrecht wrote: > I don't know either. But having both functions return conflicting values > is not something we should settle on. > > Yue Liu wrote: > I suggest write a TODO here but not change size unless one day someone > has to use a non-zero size. > > Jan Hambrecht wrote: > Or in other words: let someone else deal with that inconsistency. ;-)
So the test result is: non-zero size for group caused problems when a transformation is applied to a group since the actual bouding rect of group changes with transformations being applied on the group and it's childrens. The easy way is to cancel transformation on group, and I think that's why group size has been explicitly set as 0. So I think we should keep the group as a simple 0-size stuff but provide a method to reflect it's current state, i.e. the non-zero returned boundingRect method. - Yue ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102072/#review5355 ----------------------------------------------------------- On Aug. 3, 2011, 7:20 a.m., Yue Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102072/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2011, 7:20 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > Added support for drawing the shadow for a shape group, fixed shadow blur > zooming bug. > > > Diffs > ----- > > libs/flake/KoShapeContainer.cpp e7585ec > libs/flake/KoShapeGroup.h 5ccd574 > libs/flake/KoShapeGroup.cpp aaa58b4 > libs/flake/KoShapeShadow.h 07c760c > libs/flake/KoShapeShadow.cpp 5485b19 > libs/flake/tests/TestShapeGroupCommand.cpp 397c17b > libs/widgets/KoShadowConfigWidget.cpp 1a41042 > plugins/dockers/shadowdocker/ShadowDocker.cpp ef53fae > > Diff: http://git.reviewboard.kde.org/r/102072/diff > > > Testing > ------- > > http://my.cdash.org/viewTest.php?onlydelta&buildid=212010 > > > Screenshots > ----------- > > groupshadow / shape shadow > http://git.reviewboard.kde.org/r/102072/s/210/ > > > Thanks, > > Yue > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
