----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101820/#review4845 -----------------------------------------------------------
Hello Paul, I did not yet look at the code. However I have tested the patch and found the following: When changing the zoom level in the slide sorted only the zoom in the upper window changes not the one on the custom slide show. Both lists should be updated when changing the zoom. When the zoom is changed and then you move a item from up to down the position indicator is wrong. This is related to the not zooming of the lower (custom slide show) - Thorsten On July 18, 2011, 10:38 p.m., Paul Mendez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101820/ > ----------------------------------------------------------- > > (Updated July 18, 2011, 10:38 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > (preliminary) new GUI for manage custom slide shows. > Note: As some GUI integration is still missing, it's only a review request, > it isn't for merge with master branch. > (part of GSoC project) > > > Diffs > ----- > > kpresenter/part/CMakeLists.txt 613ff8d3de84a19776df1651c0bd3604fc395099 > kpresenter/part/KPrAnimationDirector.cpp > d9600e220546f5d5ed29f73e1988f3d130f69770 > kpresenter/part/KPrCustomSlideShows.h > 7d8a91b67e14e32312fd2706dcede6efac6e1aa7 > kpresenter/part/KPrCustomSlideShows.cpp > 632dda6b772417b3d26a84992352f9caa33ca158 > kpresenter/part/KPrCustomSlideShowsModel.h PRE-CREATION > kpresenter/part/KPrCustomSlideShowsModel.cpp PRE-CREATION > kpresenter/part/KPrDocument.h 7756f5e542738232bb3ea278453319a71d28ce9d > kpresenter/part/KPrDocument.cpp 02bf53cf087746f1942adad5db3f1e4d30a1b618 > kpresenter/part/KPrSlidesManagerView.h > 6f345e049cdf746e00fdfd9e3e7644668ff9e96e > kpresenter/part/KPrSlidesManagerView.cpp > 39e80b1b770584f97e6bfcbcebc06bd107bc1a68 > kpresenter/part/KPrSlidesSorterDocumentModel.h > a5b65a4d87f8af6a51b4e1992c2ac2a3d23aed37 > kpresenter/part/KPrSlidesSorterDocumentModel.cpp > 4938e3696bed3fb90c017aba5997c40268ce3e99 > kpresenter/part/KPrSlidesSorterItemDelegate.h PRE-CREATION > kpresenter/part/KPrSlidesSorterItemDelegate.cpp PRE-CREATION > kpresenter/part/KPrView.h a558a2e171731a2390bf5a709a829132082b993b > kpresenter/part/KPrView.cpp 04d502d4d61551ad0bd6dfabff9b8237e378b38c > kpresenter/part/KPrViewModePresentation.cpp > 46b61e1de8a9bdcab8bcb81ac3ea2830ff6f2e24 > kpresenter/part/KPrViewModeSlidesSorter.h > 240bd9e0c6b4158ff0726f2e72e4c79982a9ea18 > kpresenter/part/KPrViewModeSlidesSorter.cpp > 61866f8a1344e1999224444d71a46a1a21a1864e > kpresenter/part/commands/KPrAddCustomSlideShowCommand.h PRE-CREATION > kpresenter/part/commands/KPrAddCustomSlideShowCommand.cpp PRE-CREATION > kpresenter/part/commands/KPrDelCustomSlideShowCommand.h PRE-CREATION > kpresenter/part/commands/KPrDelCustomSlideShowCommand.cpp PRE-CREATION > kpresenter/part/commands/KPrDeleteSlidesCommand.h PRE-CREATION > kpresenter/part/commands/KPrDeleteSlidesCommand.cpp PRE-CREATION > kpresenter/part/commands/KPrEditCustomSlideShowsCommand.h PRE-CREATION > kpresenter/part/commands/KPrEditCustomSlideShowsCommand.cpp PRE-CREATION > kpresenter/part/commands/KPrRenameCustomSlideShowCommand.h PRE-CREATION > kpresenter/part/commands/KPrRenameCustomSlideShowCommand.cpp PRE-CREATION > kpresenter/part/commands/KPrSetCustomSlideShowsCommand.h > 6cc29e2cd44ef4fc2b63efbc1c3187cfd4ccd198 > kpresenter/part/commands/KPrSetCustomSlideShowsCommand.cpp > 24b99969ce4cbe55a480e43e98d2ae370c20e721 > kpresenter/part/tests/CMakeLists.txt > f9b56a6ed55ebe610ae30cd21437975c00c317d1 > kpresenter/part/tests/PAMock.h PRE-CREATION > kpresenter/part/tests/TestAddCustomSlideShowCommand.h PRE-CREATION > kpresenter/part/tests/TestAddCustomSlideShowCommand.cpp PRE-CREATION > kpresenter/part/tests/TestDelCustomSlideShowCommand.h PRE-CREATION > kpresenter/part/tests/TestDelCustomSlideShowCommand.cpp PRE-CREATION > kpresenter/part/tests/TestEditCustomSlideShowsCommand.h PRE-CREATION > kpresenter/part/tests/TestEditCustomSlideShowsCommand.cpp PRE-CREATION > kpresenter/part/tests/TestRenameCustomSlideShowCommand.h PRE-CREATION > kpresenter/part/tests/TestRenameCustomSlideShowCommand.cpp PRE-CREATION > kpresenter/part/ui/KPrConfigureSlideShowDialog.h > 1c7794a2ff08e096b8a86cf2673db0e6f206eeb6 > kpresenter/part/ui/KPrConfigureSlideShowDialog.cpp > 847a5a54a08fb46dab34bbd828da8d1ab21c6342 > kpresenter/part/ui/KPrCustomSlideShowsDialog.h > f5d53f90ca2d1e7c53ac4779a751a8d58e384a0c > kpresenter/part/ui/KPrCustomSlideShowsDialog.cpp > da697e04426c8c8c4d8684af1da9fd10c7faac61 > kpresenter/part/ui/KPrCustomSlideShowsDialog.ui > be25bc8932809e41a139f364478d2097eaa78110 > libs/kopageapp/KoPADocument.h 9347ae9c8a302c0dc6c0139c2d1e0951cd5a6091 > libs/kopageapp/KoPADocument.cpp 2a03e42fde69f5d4b0b144ccbde915ef826de70d > libs/kopageapp/KoPADocumentStructureDocker.cpp > 02af38237e08e075934cd5110efe59e56234a9e2 > > Diff: http://git.reviewboard.kde.org/r/101820/diff > > > Testing > ------- > > build and run > > > Thanks, > > Paul > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
