I mean convention of Qt documented in the API design document by Olivier Goffart.
My 2 c. On 02/07/2011, Thorsten Zachmann <t.zachm...@zagge.de> wrote: > > >> On July 1, 2011, 10:25 p.m., Jarosław Staniek wrote: >> > kpresenter/part/KPrSlidesSorterDocumentModel.h, line 76 >> > <http://git.reviewboard.kde.org/r/101820/diff/1/?file=25792#file25792line76> >> > >> > The convetion for in-out args is to use pointers instead of >> > references (and the other arg - pageAfter - uses that). > > Can you please point out the place where this convention is said. However as > the value is not used afterwards I guess passing as a reference is just so > it can be modified. If that is the case it should be change to > QList<KoPAPageBase *> slides or it should pass a const reference and make a > copy of that in the function. > > > - Thorsten > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101820/#review4297 > ----------------------------------------------------------- > > > On July 1, 2011, 10:11 p.m., Paul Mendez wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://git.reviewboard.kde.org/r/101820/ >> ----------------------------------------------------------- >> >> (Updated July 1, 2011, 10:11 p.m.) >> >> >> Review request for Calligra. >> >> >> Summary >> ------- >> >> (preliminary) new GUI for manage custom slide shows. >> Note: As some GUI integration is still missing, it's only a review >> request, it isn't for merge with master branch. >> (part of GSoC project) >> >> >> Diffs >> ----- >> >> kpresenter/part/CMakeLists.txt 613ff8d3de84a19776df1651c0bd3604fc395099 >> kpresenter/part/KPrCustomSlideShows.h >> 7d8a91b67e14e32312fd2706dcede6efac6e1aa7 >> kpresenter/part/KPrCustomSlideShows.cpp >> 4088a7446d2992d3d56059bec4ad646b4bbfc77f >> kpresenter/part/KPrCustomSlideShowsModel.h PRE-CREATION >> kpresenter/part/KPrCustomSlideShowsModel.cpp PRE-CREATION >> kpresenter/part/KPrSlidesManagerView.h >> 6f345e049cdf746e00fdfd9e3e7644668ff9e96e >> kpresenter/part/KPrSlidesManagerView.cpp >> 39e80b1b770584f97e6bfcbcebc06bd107bc1a68 >> kpresenter/part/KPrSlidesSorterDocumentModel.h >> a5b65a4d87f8af6a51b4e1992c2ac2a3d23aed37 >> kpresenter/part/KPrSlidesSorterDocumentModel.cpp >> 4938e3696bed3fb90c017aba5997c40268ce3e99 >> kpresenter/part/KPrSlidesSorterItemDelegate.h PRE-CREATION >> kpresenter/part/KPrSlidesSorterItemDelegate.cpp PRE-CREATION >> kpresenter/part/KPrViewModeSlidesSorter.h >> 240bd9e0c6b4158ff0726f2e72e4c79982a9ea18 >> kpresenter/part/KPrViewModeSlidesSorter.cpp >> 61866f8a1344e1999224444d71a46a1a21a1864e >> kpresenter/part/commands/KPrAddCustomSlideShowCommand.h PRE-CREATION >> kpresenter/part/commands/KPrAddCustomSlideShowCommand.cpp PRE-CREATION >> kpresenter/part/commands/KPrDelCustomSlideShowCommand.h PRE-CREATION >> kpresenter/part/commands/KPrDelCustomSlideShowCommand.cpp PRE-CREATION >> kpresenter/part/commands/KPrEditCustomSlideShowsCommand.h PRE-CREATION >> kpresenter/part/commands/KPrEditCustomSlideShowsCommand.cpp PRE-CREATION >> >> kpresenter/part/commands/KPrRenameCustomSlideShowCommand.h PRE-CREATION >> kpresenter/part/commands/KPrRenameCustomSlideShowCommand.cpp >> PRE-CREATION >> kpresenter/part/tests/CMakeLists.txt >> f9b56a6ed55ebe610ae30cd21437975c00c317d1 >> kpresenter/part/tests/PAMock.h PRE-CREATION >> kpresenter/part/tests/TestEditCustomSlideShowsCommand.h PRE-CREATION >> kpresenter/part/tests/TestEditCustomSlideShowsCommand.cpp PRE-CREATION >> >> Diff: http://git.reviewboard.kde.org/r/101820/diff >> >> >> Testing >> ------- >> >> build and run >> >> >> Thanks, >> >> Paul >> >> > > -- regards / pozdrawiam, Jaroslaw Staniek http://www.linkedin.com/in/jstaniek Kexi & KOffice (http://www.kexi-project.org, http://www.koffice.org) KDE Software Development Platform on MS Windows (http://windows.kde.org) _______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
