On Thu, 19 Mar 2026 19:26:02 GMT, Coleen Phillimore <[email protected]> wrote:
> This change makes UseCompactObjectHeaders default and switches the sense of > the CDS archive naming. Now classes.jsa is with UseCompressedOops + > UseCompactObjectHeaders (both default). Then theres: > classes_nocoops.jsa > classes_nocoh.jsa > classes_nocoops_nocoh.jsa > > Hopefully someday we won't need the nocoh versions. > > Tested with tier1-8. With only one issue also fixed in this change, and no > other new issues found. > > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Changes requested by rkennke (Reviewer). src/hotspot/share/cds/cdsConfig.cpp line 143: > 141: } > 142: if (!UseCompactObjectHeaders) { > 143: // Note that generation of xxx_coh.jsa variants require Also fix the comment? There is no _coh variant anymore. src/hotspot/share/runtime/arguments.cpp line 3786: > 3784: // If UseCompactObjectHeaders is on the command line, turn on > UseObjectMonitorTable. > 3785: if (FLAG_IS_CMDLINE(UseCompactObjectHeaders)) { > 3786: if (FLAG_IS_CMDLINE(UseObjectMonitorTable)) { I think this should not be inside if (FLAG_IS_CMDLINE(UseCompactObjectHeaders)) { .. }. Even if UCOH is not specified at all, we want to warn when somebody tries to turn UOMT off. Right? src/hotspot/share/runtime/arguments.cpp line 3792: > 3790: > 3791: // If UseObjectMonitorTable is on the command line, turn off > UseCompactObjectHeaders. > 3792: } else if (FLAG_IS_CMDLINE(UseObjectMonitorTable)) { And then this branch would be unnecessary. ------------- PR Review: https://git.openjdk.org/jdk/pull/30322#pullrequestreview-4120003638 PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3092366942 PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3092392037 PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3092407379
