On Thu, 19 Mar 2026 19:26:02 GMT, Coleen Phillimore <[email protected]> wrote:

> This change makes UseCompactObjectHeaders default and switches the sense of 
> the CDS archive naming.  Now classes.jsa is with UseCompressedOops + 
> UseCompactObjectHeaders (both default).  Then theres:
> classes_nocoops.jsa
> classes_nocoh.jsa
> classes_nocoops_nocoh.jsa
> 
> Hopefully someday we won't need the nocoh versions.
> 
> Tested with tier1-8.  With only one issue also fixed in this change, and no 
> other new issues found.
> 
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

I'm happy with this! Thanks for fixing Coleen.

test/hotspot/jtreg/runtime/CommandLine/VMOptionWarning.java line 121:

> 119:             }
> 120:             case "CompactObjectHeaders": {
> 121:                 pb = 
> ProcessTools.createLimitedTestJavaProcessBuilder("-XX:+UseCompactObjectHeaders",
>  "-XX:-UseObjectMonitorTable", "-version");

Suggestion:

                pb = 
ProcessTools.createLimitedTestJavaProcessBuilder("-XX:+UseCompactObjectHeaders",
 "-XX:+UnlockDiagnosticVMOptions", "-XX:-UseObjectMonitorTable", "-version");

-------------

Marked as reviewed by fbredberg (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/30322#pullrequestreview-4082191007
PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3049981667

Reply via email to