On Tue, 14 Apr 2026 07:29:36 GMT, Matthias Baesken <[email protected]> wrote:

>> When building a JVM with -ffunction-sections in the C/C++ compile flags, the 
>> gtest os_linux.decoder_get_source_info_valid_vm fails and delivers another 
>> result
>> 
>> 
>> [ RUN ] os_linux.decoder_get_source_info_valid_vm
>> test/hotspot/gtest/runtime/test_os_linux.cpp:404: Failure
>> Expected equality of these values:
>>   buf
>>     Which is: "test_os_linux.cpp"
>>   "jniCheck.hpp"
>> 
>> [ FAILED ] os_linux.decoder_get_source_info_valid_vm (20 ms)
>> 
>> 
>> So for this compilation mode, it is probably better to avoid the check for 
>> this specific header.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix build without LTGC

I wonder if we could just set the CFLAGS parameter to the filter-out expression 
directly and unconditionally, since -ffunction-sections should never be passed 
to gtest whatsoever there doesn't seem to be a point in checking for LTGC and 
setting a variable based on that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30516#issuecomment-4242385209

Reply via email to