On Mon, 13 Apr 2026 11:09:34 GMT, Matthias Baesken <[email protected]> wrote:
>> When building a JVM with -ffunction-sections in the C/C++ compile flags, the >> gtest os_linux.decoder_get_source_info_valid_vm fails and delivers another >> result >> >> >> [ RUN ] os_linux.decoder_get_source_info_valid_vm >> test/hotspot/gtest/runtime/test_os_linux.cpp:404: Failure >> Expected equality of these values: >> buf >> Which is: "test_os_linux.cpp" >> "jniCheck.hpp" >> >> [ FAILED ] os_linux.decoder_get_source_info_valid_vm (20 ms) >> >> >> So for this compilation mode, it is probably better to avoid the check for >> this specific header. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Filter out the function/data sections flags from libjvm gtest build make/hotspot/lib/CompileGtest.gmk line 50: > 48: ifeq ($(ENABLE_LINKTIME_GC), true) > 49: ifeq ($(TOOLCHAIN_TYPE), gcc) > 50: GTEST_LIBJVM_CFLAGS := $(filter-out -ffunction-sections > -fdata-sections, $(JVM_CFLAGS)) Shouldn't GTEST_LIBJVM_CFLAGS be set to JVM_CFLAGS in all other cases? Otherwise it is undefined. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30516#discussion_r3077498398
