On Tue, 31 Mar 2026 13:11:15 GMT, Hannes Wallnöfer <[email protected]> wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix glitches in ClassBuilder uses
>
> test/langtools/tools/lib/builder/ClassBuilder.java line 160:
>
>> 158: public ClassBuilder setExtends(String name) {
>> 159: if (modifiers.isInterface()) {
>> 160: implementsTypes.add(name);
>
> Nit: This assumes that `setModifiers` is invoked before `setExtends`, which
> makes sense, but maybe add an explicit assert here that modifiers is not
> empty?
I should just update Modifiers.isInterface to throw an ISE if the list empty.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30435#discussion_r3016030378
