On Wed, 25 Mar 2026 22:12:27 GMT, Chen Liang <[email protected]> wrote:
>> Consider jdk.incubator.vector.Vector with immediate invisible subclass
>> jdk.incubator.vector.AbstractVector with subclasses IntVector, etc.
>> Currently sealed graph renders as if the sealed hierarchy of `Vector` only
>> has `Vector` because AbstractVector is filtered because it is not part of
>> the public API.
>>
>> I fixed this problem and also introduced some infrastructure for testing
>> general JDK-specific taglets. This particular test for sealed graph fails
>> without the taglet change and passes with the taglet change.
>
> Chen Liang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix glitches in ClassBuilder uses
Looks good, and nice to have the means for testing JDK taglets.
test/langtools/tools/lib/builder/ClassBuilder.java line 160:
> 158: public ClassBuilder setExtends(String name) {
> 159: if (modifiers.isInterface()) {
> 160: implementsTypes.add(name);
Nit: This assumes that `setModifiers` is invoked before `setExtends`, which
makes sense, but maybe add an explicit assert here that modifiers is not empty?
-------------
Marked as reviewed by hannesw (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/30435#pullrequestreview-4037276730
PR Review Comment: https://git.openjdk.org/jdk/pull/30435#discussion_r3015818250
