Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/497 was reviewed by Joel Sherrill
-- Joel Sherrill started a new discussion on testsuites/psxtests/psxhdrs/dirent/posix_getdents.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/497#note_123447 > + > +/* > + * SPDX-License-Identifier: BSD-2-Clause The SPDX should be on a line by itself at the top of the file. One line comment. This should be in the Software Engineering Guide. Unfortunately, I found a lot of files not following the correct pattern. :( -- Joel Sherrill started a new discussion on testsuites/psxtests/psxhdrs/dlfcn/dladdr.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/497#note_123448 > + */ > + > +#define _NETBSD_SOURCE Use _POSIX_C_SOURCE on all new Issue 8 APIs. -- Joel Sherrill started a new discussion on testsuites/psxtests/psxhdrs/pthread/pthread_mutex_clocklock.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/497#note_123449 > +#include <pthread.h> > + > +#ifndef _POSIX_THREADS Delete this check and make sure it is only used where appropriate. The functions associated should be in Issue 8 but [this](https://man7.org/linux/man-pages/man7/posixoptions.7.html) Linux man page should be OK to go by also. -- Joel Sherrill started a new discussion on testsuites/psxtests/psxhdrs/pthread/pthread_rwlock_clockrdlock.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/497#note_123450 > +#include <pthread.h> > + > +#ifndef _POSIX_THREADS Delete/adjust per previous comment. -- Joel Sherrill started a new discussion on testsuites/psxtests/psxhdrs/pthread/pthread_rwlock_clockwrlock.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/497#note_123451 > +#include <pthread.h> > + > +#ifndef _POSIX_THREADS Delete/adjust per previous comment. -- Joel Sherrill started a new discussion on testsuites/psxtests/psxhdrs/stdlib/quick_exit.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/497#note_123452 > +#endif > + > +#include <stdlib.h> The body of this file from 32 to end the should be wrapped in "__STDC_VERSION__ >= 201112L". The header file will not have this prototyped enabled otherwise. Probably should test that >= C11 is being used to compile the C11 methods that are also in Issue 8. Can do this with this: ``` #if (__STDC_VERSION__ < 201112L) #error "Need >= C11" #endif ``` Just to test how it is compiled. That can be deleted after confirming that it is actually built with code enabled. The newlib .h only checks C version now. It will need to have an OR Issue 8 added. -- Joel Sherrill started a new discussion on testsuites/psxtests/psxhdrs/stdlib/at_quick_exit.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/497#note_123453 > + */ > + > +#ifdef HAVE_CONFIG_H See C version comment on quick_exit.c -- Joel Sherrill started a new discussion on testsuites/psxtests/psxhdrs/time/timespec_get.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/497#note_123454 > + */ > + > +#ifdef HAVE_CONFIG_H See C version comment on quick_exit.c -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/497 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list bugs@rtems.org http://lists.rtems.org/mailman/listinfo/bugs
