On Sun, Jun 18, 2017 at 2:42 PM, David Boyce <david.s.bo...@gmail.com>
wrote:
> In the event this patch is used: I think the interleaved-ifdef style is
> hard to read and best avoided. How about either separating the Windows and
> "other" clauses at the top level or something like this (with suitable
> comment):
>
> + for (e = 0; e < 10; ++e)
> + {
> + status = unlink (file->name);
> +#ifdef WINDOWS32
> + if (status == 0 || errno == ENOENT)
> + break;
> + Sleep(5);
> +#else
> + break;
> + }
> +#endif
>
Yes, this looks a bit cleaner. But the #endif should be one line above of
course :)
- Orgad
_______________________________________________
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
