Hello Samuel, Le 31/10/2020 à 00:04, Samuel Thibault a écrit : > Hello, > > Romain Naour, le ven. 30 oct. 2020 22:37:25 +0100, a ecrit: >> libfshelp/rlock.h and libfshelp/fshelp.h use FSHELP_EXTERN_INLINE >> not FSHELP_DEFINE_EXTERN_INLINE. >> >> * libfshelp/fshelp.h: Use FSHELP_EXTERN_INLINE, not >> FSHELP_DEFINE_EXTERN_INLINE. > > But FSHELP_EXTERN_INLINE is always getting defined, so that makes the > #if moot.
Indeed. At first look the commit [1] seemed to me to introduce a typo FSHELP_DEFINE_EXTERN_INLINE instead of FSHELP_EXTERN_INLINE. > > I'd say rather make libfshelp/fshelp.h and libfshelp/extern-inline.c > coherent with libdiskfs's way of using FOO_DEFINE_EXTERN_INLINE. Others > (ext2fs, libpipe, etc.) are doing the same. You mean using FSHELP_DEFINE_EI and FSHELP_EI ? [1] https://git.savannah.gnu.org/cgit/hurd/hurd.git/commit/?id=ca3d36201329f0e21b995d831ce9f6f03b6b985e Best regards, Romain > > Samuel >
