Hello, Romain Naour, le ven. 30 oct. 2020 22:37:25 +0100, a ecrit: > libfshelp/rlock.h and libfshelp/fshelp.h use FSHELP_EXTERN_INLINE > not FSHELP_DEFINE_EXTERN_INLINE. > > * libfshelp/fshelp.h: Use FSHELP_EXTERN_INLINE, not > FSHELP_DEFINE_EXTERN_INLINE.
But FSHELP_EXTERN_INLINE is always getting defined, so that makes the #if moot. I'd say rather make libfshelp/fshelp.h and libfshelp/extern-inline.c coherent with libdiskfs's way of using FOO_DEFINE_EXTERN_INLINE. Others (ext2fs, libpipe, etc.) are doing the same. Samuel