Justus Winter, le Mon 26 May 2014 13:19:13 +0200, a écrit :
> I tested this change for some days and have not experienced any
> problems with it.
Ack.
> * term/users.c (pi_destroy_hook): Fix memory leak.
> ---
> term/users.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/term/users.c b/term/users.c
> index 97bc22c..9bd51d0 100644
> --- a/term/users.c
> +++ b/term/users.c
> @@ -259,9 +259,7 @@ pi_destroy_hook (struct trivfs_protid *cred)
> {
> assert (((struct protid_hook *)cred->hook)->refcnt > 0);
> if (--((struct protid_hook *)cred->hook)->refcnt == 0)
> - /* XXX don't free for now, so we can try and catch a multiple-freeing
> - bug. */
> - /* free (cred->hook) */;
> + free (cred->hook);
> }
> pthread_mutex_unlock (&global_lock);
> }
> --
> 2.0.0.rc2
>
--
Samuel
The only "intuitive" interface is the nipple. After that, it's all learned.
(Bruce Ediger, [email protected], in comp.os.linux.misc, on X interfaces.)
