Re: [PATCH 3/7] name_equal: return early from function if src null-terminates in the loop

[Neal H. Walfield]

At Fri, 13 Sep 2013 13:31:53 +0200,
Marin Ramesa wrote:
> diff --git a/device/dev_name.c b/device/dev_name.c
> index bf541df..6ce4b19 100644
> --- a/device/dev_name.c
> +++ b/device/dev_name.c
> @@ -69,9 +69,12 @@ name_equal(src, len, target)
>       int     len;
>       char    *target;
>  {
> -     while (--len >= 0)
> +     while (--len >= 0) {
>           if (*src++ != *target++)
>               return FALSE;
> +         if (*src == '\0' && *target != '\0')
> +             return FALSE;
> +     }

Shouldn't this return TRUE?

Neal