Hi, On Wed, Dec 23, 2009 at 10:52:14PM +0530, Shakthi Kannan wrote:
> 1. version.h is located in /usr/include/hurd/version.h, so hello.c > should include? > > === PATCH === > > -#include <version.h> > +#include <hurd/version.h> > > === END === I guess the hurd/ prefix is not necessary when building in-tree. As I already said on IRC, the file was never meant to be compiled standalone. But perhaps it still works with the Prefix even in-tree... Could you test that? If so, it might be useful to do the change anyways, just to keep things uniform. > 2. trivfs_modify_stat struct stat *st argument has changed to io_statbuf_t > *st? > > === PATCH === > > void > -trivfs_modify_stat (struct trivfs_protid *cred, struct stat *st) > +trivfs_modify_stat (struct trivfs_protid *cred, io_statbuf_t *st) This actually sound like it should be the same?... Not sure why the in-tree version would see "struct stat" and the out-of-tree version not. > 3. trivfs_S_io_seek API has changed as well. Are the following changes > correct? > > === PATCH === > > /* Change current read/write offset */ > error_t > -trivfs_S_io_seek (struct trivfs_protid *cred, > +trivfs_S_io_seek (trivfs_protid_t io_object, Same here. As for the actual name of the parameter, it shouldn't matter. > mach_port_t reply, mach_msg_type_name_t reply_type, > - off_t offs, int whence, off_t *new_offs) > + loff_t offs, int whence, loff_t *new_offs) This is probably the same when compiling with -D_FILE_OFFSET_BITS=64 ? At least it sounds like this would be related... -antrik-
