Hello, On Wed, Dec 23, 2009 at 10:52:14PM +0530, Shakthi Kannan wrote: > >From git://git.sv.gnu.org/hurd/hurd.git, > > On commit 908ba8441182f34a7b565a692ebb60e8af321d17, some > clarifications on hurd/trans/hello.c: > > 1. version.h is located in /usr/include/hurd/version.h, so hello.c > should include? > > === PATCH === > > -#include <version.h> > +#include <hurd/version.h> > > === END ===
I'd say it would be better if you had just posted the whole set of your changes as a single patch with the necessary comments, both because this way your E-mail is ready to be applied as a patch and because it's less work for you to arrange modifications in separate sections :-) > 2. trivfs_modify_stat struct stat *st argument has changed to io_statbuf_t > *st? > > === PATCH === > > void > -trivfs_modify_stat (struct trivfs_protid *cred, struct stat *st) > +trivfs_modify_stat (struct trivfs_protid *cred, io_statbuf_t *st) > > === END === > > 3. trivfs_S_io_seek API has changed as well. Are the following changes > correct? > > === PATCH === > > /* Change current read/write offset */ > error_t > -trivfs_S_io_seek (struct trivfs_protid *cred, > +trivfs_S_io_seek (trivfs_protid_t io_object, > mach_port_t reply, mach_msg_type_name_t reply_type, > - off_t offs, int whence, off_t *new_offs) > + loff_t offs, int whence, loff_t *new_offs) > { > struct open *op; > error_t err = 0; > - if (! cred) > + if (! io_object) > return EOPNOTSUPP; > > - op = cred->po->hook; > + op = io_object->po->hook; > switch (whence) > > === END === These changes seem okay to me. I can remember having issues with using off_t instead of loff_t myself (though I can recall where). > I would like to know how I can get prints inside translator code to > a file or some log? Printing to a file is nothing fancy: the fprintf functions should suffice. Also, some translators use the error () function for debugging purposes (unionfs, eth-multiplexer). In this way you will get messages to the shell you've started the translator from. Regards, Sergiu