Hi, On Sun, May 31, 2009 at 11:01:21AM +0200, olafbuddenha...@gmx.net wrote: > > On Fri, May 29, 2009 at 12:09:04AM +0300, Sergiu Ivanov wrote: > > > +/*---------------------------------------------------------------------------*/ > > +#include "unionmount.h" > > +/*---------------------------------------------------------------------------*/ > > + > > +/*---------------------------------------------------------------------------*/ > > +/*---------Global > > Variables--------------------------------------------------*/ > > +/*The command line for starting the translator. */ > > +char * trans_argz; > > +size_t trans_argz_len; > > +/*---------------------------------------------------------------------------*/ > [...] > > Please drop these crazy comment "lines"... I'm not going to discuss the > aesthetic value of such ornaments :-) -- but please try to keep > consistent with the style of the existing code.
Also the normal way to section code in the Hurd is the page feed character (^L). There are plenty of examples in the Hurd's source. > Also, I don't think a comment saying "global variables" is exactly > useful -- this is really obvious to any C programmer... I think it's acceptable if used as a ``Global variables goes here'' statement. Though ``Argument parsing variables'' would be more meaningful. An ``Argument parsing'' section with all code related to it would be ideal if possible IMHO. Regards, Fredrik
