Hello, On Wed, May 27, 2009 at 11:27 PM, Thomas Schwinge <tschwi...@gnu.org> wrote: >> -OBJS = main.o node.o lnode.o ulfs.o ncache.o netfs.o \ >> - lib.o options.o pattern.o stow.o update.o >> +OBJS = main.o node.o lnode.o ulfs.o ncache.o netfs.o lib.o options.o \ >> + pattern.o stow.o update.o unionmount.o > > This is not really that important here (and the same applies to my other > nit-picking by the way -- but you chose to be with those picky Hurd > people, didn't you?), but as a guideline for forthcoming situations, and > to make reviewing your changes easier: try to preserve as much as is > possible from the previous version. (As long as is sensible, of course.)
OK, thank you. I'll keep that in mind. > I hope you don't mind if I give comments like these. You don't have to > subscribe to all of them right now, but perhaps you can keep such things > in the back of your head. It's great that you give comments like these :-) It's a considerable update to my knowledge and it will make me more compatible with normal coding procedure :-) >> diff --git a/options.c b/options.c >> index beed9f4..c12974c 100644 >> --- a/options.c >> +++ b/options.c >> @@ -6,12 +6,12 @@ >> modify it under the terms of the GNU General Public License as >> published by the Free Software Foundation; either version 2 of the >> License, or * (at your option) any later version. >> - >> + > > Please try to avoid such whitespace changes. If there is really > something that needs to be changed, then do that separately. I could have never supposed that a diff could possibly contain such lines... I just didn't look over my patch at all initially... I guess it's because of M-x delete-trailing-whitespace thing... > There is an embedded asterisk. (Switching to GPLv3+ is another > discussion, for later on.) I hope I understood correctly what ``embedded asterisk'' means... Regards, scolobb
