On Thu, Mar 14, 2002 at 07:47:06PM -0800, James Morrison wrote: > it would make things more consistant. Are there any more consistancy > things I should look for while reading through more code?
Some wrong formatting slipped through, like "if ( foo == bar )", drop the spaces close to the parens, and sometimes you forgot to correct indentation of subsequent lines. And don't put discussion about code into comments of the code, mixed with your changes. Raise the issue visibly on the list, in the same mail before the patch or in a seperate mail. The path /gnu/gc etc is certainly wrong, you can probably just replace it with sys/ioctl.h, although thecode is obviously defunct anyway. I have not checked why it wants to include the file. Thanks, Marcus _______________________________________________ Bug-hurd mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-hurd
