On Wed, Jun 11, 2025 at 6:05 AM Christian Brauner <brau...@kernel.org> wrote:
>
> On Tue, Jun 10, 2025 at 07:50:10PM -0400, Paul Moore wrote:
> > On Fri, Jun 6, 2025 at 1:39 AM Collin Funk <collin.fu...@gmail.com> wrote:
> > > Paul Moore <p...@paul-moore.com> writes:
> > > >> <stephen.smalley.w...@gmail.com> wrote:
> > > >> >
> > > >> > commit 8b0ba61df5a1 ("fs/xattr.c: fix simple_xattr_list to always
> > > >> > include security.* xattrs") failed to reset err after the call to
> > > >> > security_inode_listsecurity(), which returns the length of the
> > > >> > returned xattr name. This results in simple_xattr_list() incorrectly
> > > >> > returning this length even if a POSIX acl is also set on the inode.
> > > >> >
> > > >> > Reported-by: Collin Funk <collin.fu...@gmail.com>
> > > >> > Closes: https://lore.kernel.org/selinux/8734ceal7q....@gmail.com/
> > > >> > Reported-by: Paul Eggert <egg...@cs.ucla.edu>
> > > >> > Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2369561
> > > >> > Fixes: 8b0ba61df5a1 ("fs/xattr.c: fix simple_xattr_list to always
> > > >> > include security.* xattrs")
> > > >> >
> > > >> > Signed-off-by: Stephen Smalley <stephen.smalley.w...@gmail.com>
> > > >> > ---
> > > >> > fs/xattr.c | 1 +
> > > >> > 1 file changed, 1 insertion(+)
> > > >>
> > > >> Reviewed-by: Paul Moore <p...@paul-moore.com>
> > > >
> > > > Resending this as it appears that Stephen's original posting had a
> > > > typo in the VFS mailing list. The original post can be found in the
> > > > SELinux archives:
> > > >
> > > > https://lore.kernel.org/selinux/20250605164852.2016-1-stephen.smalley.w...@gmail.com/
> > >
> > > Hi, responding to this message since it has the correct lists.
> > >
> > > I just booted into a kernel with this patch applied and confirm that it
> > > fixes the Gnulib tests that were failing.
> > >
> > > Reviewed-by: Collin Funk <collin.fu...@gmail.com>
> > > Tested-by: Collin Funk <collin.fu...@gmail.com>
> > >
> > > Thanks for the fix.
> >
> > Al, Christian, are either of you going to pick up this fix to send to
> > Linus? If not, any objection if I send this up?
>
> It's been in vfs.fixes for some time already and it'll go out with the
> first round of post -rc1 fixes this week.
Great, thanks. I didn't see any replies on-list indicating that the
patch had been picked up, so I just wanted to make sure someone was
sending this up to Linus.
--
paul-moore.com
