On Thu, Jun 5, 2025 at 12:49 PM Stephen Smalley <[email protected]> wrote: > > commit 8b0ba61df5a1 ("fs/xattr.c: fix simple_xattr_list to always > include security.* xattrs") failed to reset err after the call to > security_inode_listsecurity(), which returns the length of the > returned xattr name. This results in simple_xattr_list() incorrectly > returning this length even if a POSIX acl is also set on the inode. > > Reported-by: Collin Funk <[email protected]> > Closes: https://lore.kernel.org/selinux/[email protected]/ > Reported-by: Paul Eggert <[email protected]> > Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2369561 > Fixes: 8b0ba61df5a1 ("fs/xattr.c: fix simple_xattr_list to always include > security.* xattrs") > > Signed-off-by: Stephen Smalley <[email protected]> > --- > fs/xattr.c | 1 + > 1 file changed, 1 insertion(+)
Reviewed-by: Paul Moore <[email protected]> > diff --git a/fs/xattr.c b/fs/xattr.c > index 8ec5b0204bfd..600ae97969cf 100644 > --- a/fs/xattr.c > +++ b/fs/xattr.c > @@ -1479,6 +1479,7 @@ ssize_t simple_xattr_list(struct inode *inode, struct > simple_xattrs *xattrs, > buffer += err; > } > remaining_size -= err; > + err = 0; > > read_lock(&xattrs->lock); > for (rbp = rb_first(&xattrs->rb_root); rbp; rbp = rb_next(rbp)) { > -- > 2.49.0 -- paul-moore.com
