On 17/12/2024 07:55, Simon Josefsson via Gnulib discussion list wrote:
Thanks - I have pushed this now.
Just testing this in coreutils (for use by `cksum -a crc32b`),
and it seems to be working, but only after I fix a build failure with the
attached.
Thanks for the work on this.
Pádraig
From da6b90f1fd041c013b9685ec4256e16d75b83f5d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C3=A1draig=20Brady?= <p...@draigbrady.com>
Date: Wed, 18 Dec 2024 12:53:02 +0000
Subject: [PATCH] crc-x86_64: fix build failure due to indentation
* modules/crc-x86_64: Remove indentation on lib_SOURCES,
as otherwise it's replaced with libcoreutils_a_SOURCES
rather than the required lib_libcoreutils_a_SOURCES, resulting in:
lib/gnulib.mk:1090: error: libcoreutils_a_SOURCES must be set with '=' before using '+='
lib/gnulib.mk:1090: warning: variable 'libcoreutils_a_SOURCES' is defined but no program or
lib/gnulib.mk:1090: library has 'libcoreutils_a' as canonical name (possible typo)
---
ChangeLog | 6 ++++++
modules/crc-x86_64 | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index 74d1ded7d5..cf98e92c62 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2024-12-18 Pádraig Brady <p...@draigbrady.com>
+
+ crc-x86_64: fix build failure due to indentation
+ * modules/crc-x86_64: Remove indentation on lib_SOURCES,
+ so that it's transformed correctly to lib_libcoreutils_a_SOURCES.
+
2024-12-17 Bruno Haible <br...@clisp.org>
crc-x86_64: Tweaks.
diff --git a/modules/crc-x86_64 b/modules/crc-x86_64
index 4796de054f..2e4b5bf744 100644
--- a/modules/crc-x86_64
+++ b/modules/crc-x86_64
@@ -15,7 +15,7 @@ AC_REQUIRE([gl_CRC_X86_64_PCLMUL])
Makefile.am:
if GL_CRC_X86_64_PCLMUL
- lib_SOURCES += crc-x86_64-pclmul.c
+lib_SOURCES += crc-x86_64-pclmul.c
endif
Include:
--
2.47.1
