> End sentences with '.' done
> Same here.
done
> That filename comment is now wrong.
fixed
> Is that true? If this new original code, shouldn't it say 2024? If
> this isn't new original code (does it come from coreutils), it make
> sense to add a comment saying where it is coming from, like:
fixed, code is original but copyright changed to just 2024
> Could you run 'indent' on this file? I think these should be '{ 0 }'
> and '...si128 ();' respectively.
done
> Shouldn't this be crc-x86_64-pclmul.h now?
there will be future AVX2 and AVX512 implementations, these should probably
use the same header
> Same as above.
fixed
> Add _X86_64_PCLMUL?
done
> I'm unsure about those CFLAGS. Aren't these CFLAGS required when
> building the code too? If not, why can't the same pattern to detect
> PCLMUL during ./configure which is done during run-time?
discussed with Bruno earlier in the thread, CFLAGS set this for the entire
build so we've done it with pragmas inside crc-x86_64-pclmul.c
0001-crc-Add-PCLMUL-implementation.patch
Description: Binary data
