Hi Simon, On 3/15/24 7:30 AM, Simon Josefsson wrote: > Wow it is very much faster! \o/
That result is interesting. I wonder what part takes the shell script so long. Maybe I'll use gnulib-tool as an excuse to expirement with perf, dtrace, etc. > OATH Toolkit fails with sh+py though... Yes, Bruno made that check intentionally strict since we want the output on the file system and stdout to be the same. As a result though 'gnulib-tool --version' fails with GNULIB_TOOL_IMPL=sh+py: $ gnulib-tool.sh --version > shell.version $ gnulib-tool.py --version > python.version $ diff -u shell.version python.version --- shell.version 2024-03-15 11:07:43.096218254 -0700 +++ python.version 2024-03-15 11:07:50.895221724 -0700 @@ -4,4 +4,4 @@ This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. -Written by Bruno Haible, Paul Eggert, and Simon Josefsson. +Written by Bruno Haible, Paul Eggert, Simon Josefsson, and Dmitry Selyutin. which is slightly annoying. But better too strict than not strict enough. > isn't the --local-dir part working? It doesn't notice the patches > in liboath/gl/override. I can build Coreutils and it uses --local-dir. It doesn't seem to use patches though so that very well could be broken. Thanks for letting me know. I'll look into it. > Also it seems to "forget" gl_LGPL([2]) in gnulib-cache.m4. I've run into a few "interesting" things with the output of the gnulib-cache.m4 file. See: $ gnulib-tool.py --create-testdir --dir test-python --vc-files dummy $ cd test-python $ gnulib-tool.py --import --vc-files readme-release $ grep 'VC' m4/gnulib-cache.m4 gl_VC_FILES([True]) When fixing the conversion of shell 'true' to python 'True', it seems to have uncovered that the conversion the other way around was never implemented. > From a clean checkout, you want to run this command to run all > gnulib-tool invocations for OATH Toolkit: > > make -f cfg.mk glimport Thanks. This should help me out once I finish the gnulib-tool.py.TODO items. Collin
