Hi Simon, On 3/11/24 1:06 AM, Simon Josefsson wrote: > Trying gnulib-tool.py on OATH Toolkit (which use a somewhat unorthodox > gnulib usage style by adding code into git) results in error below. I > thought it was a missing mkdir at some point, but I couldn't find a > solution... ideas?
I was going to say you were too soon to test, but it seems that the unpushed changes would not fix your issue. They have to do with generating the system header replacement code in Makefiles, but your package only uses version control / build infrastructure modules. > $GNULIB_REFDIR/gnulib-tool.py --add-import Nearly all of my testing has been done with --import and --create-testdir. Running --add-import in Coreutils gives me the following: $ gnulib-tool.py --add-import gnulib-tool: warning: file buffer-lcm does not exist gnulib-tool: warning: file cl-strtod does not exist gnulib-tool: warning: file cl-strtold does not exist gnulib-tool: warning: file fadvise does not exist gnulib-tool: warning: file fd-reopen does not exist gnulib-tool: warning: file heap does not exist gnulib-tool: warning: file randint does not exist gnulib-tool: warning: file randperm does not exist gnulib-tool: warning: file root-dev-ino does not exist gnulib-tool: warning: file skipchars does not exist gnulib-tool: warning: file smack does not exist gnulib-tool: warning: file strnumcmp does not exist gnulib-tool: warning: file targetdir does not exist gnulib-tool: warning: file xdectoint does not exist gnulib-tool: warning: file xfts does not exist Traceback (most recent call last): File "/home/collin/.local/src/gnulib/pygnulib/main.py", line 1220, in <module> main() File "/home/collin/.local/src/gnulib/pygnulib/main.py", line 936, in main filetable, transformers = importer.prepare() ^^^^^^^^^^^^^^^^^^ File "/home/collin/.local/src/gnulib/pygnulib/GLImport.py", line 866, in prepare final_modules = self.moduletable.transitive_closure(base_modules) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/collin/.local/src/gnulib/pygnulib/GLModuleSystem.py", line 829, in transitive_closure raise TypeError('each module must be a GLModule instance') TypeError: each module must be a GLModule instance So I think it is safe to say the problem occurs somewhere around there... All of those modules are Coreutils --local-dir modules. Then dynamic typing things happen. Collin