On 06/20/2011 04:34 PM, Bruno Haible wrote: > I find it reasonable to use "#ifdef PATH_MAX" in front of every use of > PATH_MAX, like POSIX requires. > >> But later on in test-getcwd, we have code >> that does #ifndef PATH_MAX, which is no longer reachable because of our >> guarantee that PATH_MAX is always defined in pathmax.h. > > No, we don't want to guarantee a PATH_MAX on GNU/Hurd. > > Here's a proposed patch: > > > 2011-06-20 Bruno Haible <br...@clisp.org> > > pathmax: Never define PATH_MAX to a non-constant expression. > * lib/pathmax.h (PATH_MAX): Don't define in terms of pathconf. > * m4/pathmax.m4 (gl_PATHMAX): Don't test for pathconf.
Looks okay to me, but let's wait to see if anyone else also has an opinion. Let's also enhance doc/posix-headers/limits.texi to mention the pathmax module and its (new) semantics of not interfering with Hurd. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
