Jim Meyering wrote:
> I noticed that the comment on _GL_INT_CONVERT still said "no side effects",
> even though the restriction is now lifted:
...
> Subject: [PATCH] intprops.h: adjust comment to match code change
>
> * lib/intprops.h (_GL_INT_CONVERT): Adjust comment: now that E is used
> only once, it *may* have side effects. Also fix an unrelated typo.
...
> -/* Return a integer value, converted to the same type as the integer
> - expression E after integer type promotion. V is the unconverted value.
> - E should not have side effects. */
> +/* Return an integer value, converted to the same type as the integer
> + expression E after integer type promotion. V is the unconverted value.
> */
> #define _GL_INT_CONVERT(e, v) (0 * (e) + (v))
There was one other:
>From cf2b9e844c9b33e342765b2cc39b1359f9cca95b Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyer...@redhat.com>
Date: Sat, 28 May 2011 13:45:12 +0200
Subject: [PATCH] intprops.h: adjust another comment to match code change *
lib/intprops.h (_GL_INT_SIGNED): Now, E may have side
effects.
---
ChangeLog | 1 +
lib/intprops.h | 2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 7251dfa..99b6a4f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -3,6 +3,7 @@
intprops.h: adjust comment to match code change
* lib/intprops.h (_GL_INT_CONVERT): Adjust comment: now that E is used
only once, it *may* have side effects. Also fix an unrelated typo.
+ (_GL_INT_SIGNED): Likewise.
2011-05-26 Simon Josefsson <si...@josefsson.org>
diff --git a/lib/intprops.h b/lib/intprops.h
index 8176679..1f6a539 100644
--- a/lib/intprops.h
+++ b/lib/intprops.h
@@ -52,7 +52,7 @@
#define TYPE_SIGNED(t) (! ((t) 0 < (t) -1))
/* Return 1 if the integer expression E, after integer promotion, has
- a signed type. E should not have side effects. */
+ a signed type. */
#define _GL_INT_SIGNED(e) (_GL_INT_NEGATE_CONVERT (e, 1) < 0)
--
1.7.5.2.660.g9f46c
