I noticed that the comment on _GL_INT_CONVERT still said "no side effects",
even though the restriction is now lifted:
>From dabf3a8df68b0d70f8aff58e96ef3f143410d502 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyer...@redhat.com>
Date: Sat, 28 May 2011 12:34:08 +0200
Subject: [PATCH] intprops.h: adjust comment to match code change
* lib/intprops.h (_GL_INT_CONVERT): Adjust comment: now that E is used
only once, it *may* have side effects. Also fix an unrelated typo.
---
ChangeLog | 6 ++++++
lib/intprops.h | 5 ++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 97f1465..7251dfa 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-05-28 Jim Meyering <meyer...@redhat.com>
+
+ intprops.h: adjust comment to match code change
+ * lib/intprops.h (_GL_INT_CONVERT): Adjust comment: now that E is used
+ only once, it *may* have side effects. Also fix an unrelated typo.
+
2011-05-26 Simon Josefsson <si...@josefsson.org>
* lib/gen-uni-tables.c: Say "gen-uni-tables.c" consistently.
diff --git a/lib/intprops.h b/lib/intprops.h
index d722648..8176679 100644
--- a/lib/intprops.h
+++ b/lib/intprops.h
@@ -22,9 +22,8 @@
#include <limits.h>
-/* Return a integer value, converted to the same type as the integer
- expression E after integer type promotion. V is the unconverted value.
- E should not have side effects. */
+/* Return an integer value, converted to the same type as the integer
+ expression E after integer type promotion. V is the unconverted value. */
#define _GL_INT_CONVERT(e, v) (0 * (e) + (v))
/* Act like _GL_INT_CONVERT (E, -V) but work around a bug in IRIX 6.5 cc; see
--
1.7.5.2.660.g9f46c
