On 10/22/2010 02:12 PM, Paul Eggert wrote:
On 10/22/10 12:58, Jim Meyering wrote:
Toeing the line in this case is counterproductive.
How about sticking with your improvement and instead
using this pragma in that file?
# pragma GCC diagnostic ignored "-Wtype-limits"
Hmm, Eric removed that line about a year ago,
complaining that it didn't work for older GCC. See:
http://lists.gnu.org/archive/html/bug-gnulib/2009-10/msg00342.html
Interesting. I may have been testing on cygwin when I wrote that mail,
which was at gcc 3.4.4 at the time (it's now at 4.3.4, and soon to be at
4.5.0). In which case that's no longer a relevant platform to be
worrying about.
Eric, is it OK for us to put this back in now? I guess the
price will be noisy compiles for people who use
older gcc versions and -Wtype-limits. For which our response
would be "either upgrade GCC, or don't use -Wtype-limits".
Or, "either upgrade GCC, or don't use ./configure --enable-gcc-warnings,
or use CFLAGS=-Wno-error". Yes, I can live with re-adding that pragma.
--
Eric Blake ebl...@redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
