On 10/22/10 12:58, Jim Meyering wrote: > Toeing the line in this case is counterproductive. > How about sticking with your improvement and instead > using this pragma in that file? > > # pragma GCC diagnostic ignored "-Wtype-limits"
Hmm, Eric removed that line about a year ago, complaining that it didn't work for older GCC. See: http://lists.gnu.org/archive/html/bug-gnulib/2009-10/msg00342.html Eric, is it OK for us to put this back in now? I guess the price will be noisy compiles for people who use older gcc versions and -Wtype-limits. For which our response would be "either upgrade GCC, or don't use -Wtype-limits". It's not a big deal either way, obviously.