Jim Meyering <j...@meyering.net> writes: > Simon Josefsson wrote: > ... >> But the checks aren't turned on by default, are they? The maintainer >> needs to invoke the specific rules manually. > > Yes, they are run as part of "make syntax-check", by default.
Ah, right. >> I'd like something like that: I think multiple projects will want these >> less-generally-useful rules so it makes sense to share them. >> >> The only thing that is missing is to make it easy for maintainers to put >> something in cfg.mk that disables some checks they don't care about, >> alternatively list the checks they do care about. > > That's already possible. > Just add names of unwanted checks to this variable in cfg.mk: > > local-checks-to-skip = ... That warrants a NEWS entry blurb that maintainers that use the 'syntax-check' rule from maintainer-makefile may want to add tests they don't care about to local-checks-to-skip. But I think that is acceptable? People should be able to adapt these things. Did you notice any other problem? Looking through the changes again, I only see syntax-check related stuff, or harmless stuff. /Simon
