Eric Blake <[email protected]> writes:

> According to Simon Josefsson on 4/1/2009 7:38 AM:
>>   AM_CONDITIONAL(HAVE_LD_OUTPUT_DEF, test "$gl_cv_ld_output_def" = "yes")
>
> You still missed the m4 quoting.

Thanks.  Is there some way to systematically find these?  A m4 code
validator or similar?

> And now that the cache can provide a value, you should protect against
> a user that inserts a bogus entry:
>
> AM_CONDITIONAL([HAVE_LD_OUTPUT_DEF],
>  [test "x$gl_cv_ld_output_def" = "xyes"])

I don't understand this part, what possible bogus entry could the user
supply that would cause

  AM_CONDITIONAL([HAVE_LD_OUTPUT_DEF], test "$gl_cv_ld_output_def" = "yes")

to fail?

/Simon


Reply via email to