Hi Ben,
> I broke up the monolithic
> patch into four smaller patches as you requested.
Thanks a lot; it is much easier to review this way.
Part 1 is perfect (just an extraneous space in the ChangeLog entry).
Part 2: In m4/isnand.m4 the variable gl_func_isnand looks unused; can you add
a comment saying that it's used by isnan.m4?
The body of gl_BUILD_ISNAND has too much indentation. The
last line of macro gl_HAVE_ISNAND_NO_LIBM is also too much indented.
But otherwise it looks perfect.
Part 3: The body of gl_BUILD_ISNANF has too much indentation. Otherwise perfect
as well.
Part 4: The last line of the ChangeLog entry is extraneous.
The body of gl_BUILD_ISNANL has too much indentation.
gl_ISNAN needs to start with AC_REQUIRE([gl_MATH_H_DEFAULTS]) because
it sets REPLACE_ISNAN, assuming that REPLACE_ISNAN has its default
value set before.
Great work! Please apply these 4 patches.
Bruno