Simon Josefsson <[EMAIL PROTECTED]> writes:

> Ben Pfaff <[EMAIL PROTECTED]> writes:
>
>> +Gnulib module: isnan
>>  
>>  Portability problems fixed by Gnulib:
>>  @itemize
>> [EMAIL PROTECTED]
>> +This macro is missing on some platforms and does not always yield
>> +correct results on others.
>>  @end itemize
>
> Hi Ben!  A minor comment: If you know which platforms isnan is missing
> on, and which platforms it results in incorrect results, that may be
> useful information to add.  Also, knowing which inputs result in
> incorrect output may also be useful.  If it is complicated to explain,
> perhaps the self-test or m4 test is a better place for such discussions,
> but I could not find any similar change for that area in your patch (but
> I could have missed it).

Thanks for keeping me honest.  I'll definitely improve this
before I push anything.  I don't have a good list of platforms on
which isnan is missing, because Bruno's list by platform only
covers functions, but I can do better than what is given here.  I
can come up with some platforms that have incorrect results by
merging the docs for isnanf and isnanl.
-- 
Ben Pfaff 
http://benpfaff.org



Reply via email to