Jim Meyering <[EMAIL PROTECTED]> writes: > Simon Josefsson <[EMAIL PROTECTED]> wrote: >> Let's not wait for glibc to install my patch... What do you think >> about installing the following in gnulib now? It would sync gnulib >> with my proposed libc-patch. It also fixes the sha1 module to be >> standalone. > > I like it. Thanks for the clean-up. > I suppose you've done at least a little portability testing?
No. I'll do that next. I can't test the sha1 module easily right now though. > A quick glance through the diffs showed only one nit: > >> - IMPORTANT: On some systems it is required that RESBUF be correctly >> + IMPORTANT: On some systems it is required that RESBUF is correctly >> aligned for a 32 bits value. */ > > Please don't make that change. > Using `be' there is actually correct, but the sentence > should be changed. How about this instead? > > IMPORTANT: On some systems, RESBUF must be aligned to a 32-bit boundary. I have fixed my local copy, and updated the glibc bug report. Thanks, Simon _______________________________________________ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib
