Paul Eggert wrote: >Derek Price <[EMAIL PROTECTED]> writes: > > > >>Fair enough, but why undo the change to glob.m4? Shouldn't I just >>change the target of the AC_DEFINE from MISSING_SYS_CDEFS_H to _SYS_CDEFS_H? >> >> > >Yes, you're right. > >Sorry, I'd forgotten the trick that I had suggested. (This suggests >that it deserves a nice fat comment. :-) > >
Done. I added this comment to both glob_.h & glob.m4, with different comment leaders, of course: /* Note the reversal of the common HAVE_SYS_CDEFS_H idiom below. In this way, #ifndef _SYS_CDEFS_H may be used to include <sys/cdefs.h> both when it has been checked for via the GNULIB configure test and found and when it has not been checked for, which we can presume means that the <glob.h> GNULIB shares with GLIBC is being included as a system header and not as part of GNULIB, in which case <sys/cdefs.h> may be assumed. */ I'm going to commit what I have as the new glob module soon if noone says otherwise. I and the CVS team made a few more minor changes to make it work on Solaris, BSD, and Windows, but it is now compiling and running on some 7 diverse platforms. After that I will write up a ChangeLog entry for the glob-glibc2gnulib diff and submit our changes back to the glibc team, unless someone here who is used to working with them would like to take a go at the actual submission part. Perhaps it would be smoother if someone already known to the glibc team introduced me and this patch? Is the "definitive" version of shared files usually in glibc, gnulib, or wherever someone last remembered to merge when this happens? Cheers, Derek _______________________________________________ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib
