https://sourceware.org/bugzilla/show_bug.cgi?id=33631

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Sam James from comment #1)
> Do we want this?
> 
> ```
> --- a/ld/testsuite/ld-elfvers/vers.exp
> +++ b/ld/testsuite/ld-elfvers/vers.exp
> @@ -853,7 +853,7 @@ if [string match "yes" $pic] then {
>  # command line as if it were a normal .o file.
>  #
>  catch "exec cp $srcdir/$subdir/vers8.map $tmpdir/" ignore_output
> -build_vers_lib_pic "vers8" vers1.c vers8 vers8.map "" vers8.ver vers1.dsym
> vers1.sym
> +build_vers_lib_pic "vers8" vers8.c vers8 vers8.map "" vers8.ver vers1.dsym
> vers1.sym
> ```

There are:

vers1.c  vers1.dsym  vers1.map  vers1.sym  vers1.ver

and

vers8.c  vers8.map  vers8.ver

The differences are

[hjl@gnu-tgl-3 ld-elfvers]$ diff -up vers1.map vers8.map
--- vers1.map   2021-11-20 09:48:23.217996580 +0800
+++ vers8.map   2021-11-20 09:48:23.218996582 +0800
@@ -1,13 +1,15 @@
-VERS_1.1 {
-        local:
-                hide_old*; 
-                hide_original*; 
-                hide_new*; 
-};
-
-VERS_1.2 {
-} VERS_1.1;
-
-VERS_2.0 {
-                show_bar1; show_bar2;
-} VERS_1.2;
+VERSION {
+       VERS_1.1 {
+                local:
+                        hide_old*; 
+                        hide_original*; 
+                        hide_new*; 
+       };
+       
+       VERS_1.2 {
+       } VERS_1.1;
+       
+       VERS_2.0 {
+                        show_bar1; show_bar2;
+       } VERS_1.2;
+}
[hjl@gnu-tgl-3 ld-elfvers]$ diff -up vers1.ver vers8.ver
--- vers1.ver   2021-11-20 09:48:23.217996580 +0800
+++ vers8.ver   2021-11-20 09:48:23.218996582 +0800
@@ -1,5 +1,5 @@
 Version definitions:
-[1-4] 0x01 0x0c96425f vers1.so
+[1-4] 0x01 0x0c96b25f vers8.so
 [1-4] 0x00 0x0a7927b1 VERS_1.1
 [1-4] 0x00 0x0a7927b2 VERS_1.2
        VERS_1.1 
[hjl@gnu-tgl-3 ld-elfvers]$ 

We should simply remove vers8.c.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Reply via email to