On 10/25/11 4:54 PM, David Binderman wrote:
>
>
> Hello there,
>
> I just ran the static analysis tool cppcheck over the source
> code of bash-4.2
>
> It said
>
> [bash-4.2/builtins/mkbuiltins.c:554]: (style) Array index i is used before
> limits check
>
> The source code is
>
> while (buffer[i] != '\n' && i < file_size)
> i++;
>
> You might be better off with
>
> while (i < file_size && buffer[i] != '\n')
> i++;
Thanks for the report. I'd be interested in other issues that tool
reports.
Chet
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU c...@case.edu http://cnswww.cns.cwru.edu/~chet/
