bash-4.2: poor order of conditionals

[David Binderman]

Hello there,

I just ran the static analysis tool cppcheck over the source
code of bash-4.2

It said

[bash-4.2/builtins/mkbuiltins.c:554]: (style) Array index i is used before 
limits check

The source code is

      while (buffer[i] != '\n' && i < file_size)
        i++;

You might be better off with

      while (i < file_size && buffer[i] != '\n')
        i++;


Regards

David Binderman